Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed errors that CI workflow caught #285

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

AdamFinkle
Copy link
Collaborator

No description provided.

@AdamFinkle AdamFinkle merged commit 98edbe0 into main Dec 16, 2024
8 checks passed
@ethanstrominger ethanstrominger deleted the functional_programming branch December 16, 2024 23:32
AdamFinkle added a commit that referenced this pull request Jan 22, 2025
commit 2d09a76
Author: Derek McIntire <[email protected]>
Date:   Tue Jan 21 19:44:27 2025 -0500

    Fix tsconfig.json and Lint errors (#290)

    * fixed all ts errors and lint warnings

    * Add comments to tsconfig

    * Don't override includes

    * add stuff

    * change target to ES2020

    * add exclude list

    * remove commented out lines

    * More explicit exclude

    * try include as well as exclude

    * Letting claude give it a try

    * I dont think build is a hidden directory

    * undo claude

    * Type check working now

    * fix eslint comment as well

    * Add noUncheckedIndexAccess

commit ab29024
Author: Derek McIntire <[email protected]>
Date:   Tue Jan 14 20:42:54 2025 -0500

    223 heatload graph (#288)

    * Use rules engine output to populate heat load graph

    * update graph record type

    * run prettier for select files

    * fix dataKeys

    * Use correct data and make chart pretty

    * Graph working, but needs clean up

    * Clean up and comments

    * Comments on calculation functions

    * Add icon, still need to add values underneath chart

    * restore ws changes to types

    * Add columns at bottom of chart

    * Fix reversed average and max in grid

    * Fix responsiveness issues

    * Extract utility and data building functions, tool tip and constants

    * Add comment with link to external calculation docs

    * Fix tool tip

    * quick refactor

    * clean up

    * refactor calculating min and max for Y axis

    * set start and end temps once

    * Add 2f to x axis so tool tip is easier to invoke

    * review changes to HeatLoad.tsx

    * All issues except legend and tool type type errors addressed

    * legend working with valid value for layout

    * break out legend and fix avg heat load endpoint

    * Adjust x axis ticks and make design set point a global constant

    * fix HeatLoadGraphToolTip type error

    * Remove hard coded data

    * Add comment to calculateAvgHeatLoadEndPoint

    * comment out inclusion_override

    * Fix type errors

    * re-comment tsconfig

commit 98edbe0
Author: AdamFinkle <[email protected]>
Date:   Mon Dec 16 15:22:38 2024 -0500

    Fixed errors that CI workflow caught (#285)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant